Fix crash in remoteDispatchDomainMemoryStats (CVE-2013-4296)
authorDaniel P. Berrange <berrange@redhat.com>
Tue, 3 Sep 2013 15:52:06 +0000 (16:52 +0100)
committerEric Blake <eblake@redhat.com>
Wed, 18 Sep 2013 21:43:50 +0000 (15:43 -0600)
commit455de1215cc921efcd2b210f129f55c27445d623
tree4589913da4cf1e73f663fd3d2d0ef59ec64b2bfc
parent77d448e15d73773d5ffe00b62dbdbc0380c4faae
Fix crash in remoteDispatchDomainMemoryStats (CVE-2013-4296)

The 'stats' variable was not initialized to NULL, so if some
early validation of the RPC call fails, it is possible to jump
to the 'cleanup' label and VIR_FREE an uninitialized pointer.
This is a security flaw, since the API can be called from a
readonly connection which can trigger the validation checks.

This was introduced in release v0.9.1 onwards by

  commit 158ba8730e44b7dd07a21ab90499996c5dec080a
  Author: Daniel P. Berrange <berrange@redhat.com>
  Date:   Wed Apr 13 16:21:35 2011 +0100

    Merge all returns paths from dispatcher into single path

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
(cherry picked from commit e7f400a110e2e3673b96518170bfea0855dd82c0)

Conflicts:
daemon/remote.c - context
daemon/remote.c