Fix crash in remoteDispatchDomainMemoryStats (CVE-2013-4296)
authorDaniel P. Berrange <berrange@redhat.com>
Tue, 3 Sep 2013 15:52:06 +0000 (16:52 +0100)
committerEric Blake <eblake@redhat.com>
Wed, 18 Sep 2013 19:41:58 +0000 (13:41 -0600)
commit6d1acf71955c0d02168217ad0a87ef8b779e0f89
tree3b2892babdcfd33f17fc709d4f095bb3e17c0d7d
parenta338c40b8a800b0edc372d433ec5d4411e8af8ea
Fix crash in remoteDispatchDomainMemoryStats (CVE-2013-4296)

The 'stats' variable was not initialized to NULL, so if some
early validation of the RPC call fails, it is possible to jump
to the 'cleanup' label and VIR_FREE an uninitialized pointer.
This is a security flaw, since the API can be called from a
readonly connection which can trigger the validation checks.

This was introduced in release v0.9.1 onwards by

  commit 158ba8730e44b7dd07a21ab90499996c5dec080a
  Author: Daniel P. Berrange <berrange@redhat.com>
  Date:   Wed Apr 13 16:21:35 2011 +0100

    Merge all returns paths from dispatcher into single path

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
(cherry picked from commit e7f400a110e2e3673b96518170bfea0855dd82c0)

Conflicts:
daemon/remote.c - context
daemon/remote.c