CVE-2013-6456: Avoid unsafe use of /proc/$PID/root in LXC shutdown/reboot code
authorEric Blake <eblake@redhat.com>
Tue, 24 Dec 2013 05:55:51 +0000 (22:55 -0700)
committerDaniel P. Berrange <berrange@redhat.com>
Tue, 18 Feb 2014 15:53:09 +0000 (15:53 +0000)
commit807db4a30ee903f973d496b3293d9e6aaa511174
treec3f8c054aa4bf13e6d4fc0b05325cb91b9ac86eb
parent7f406359975173c6959aa5d33e22bc8c6752ee7b
CVE-2013-6456: Avoid unsafe use of /proc/$PID/root in LXC shutdown/reboot code

Use helper virProcessRunInMountNamespace in lxcDomainShutdownFlags and
lxcDomainReboot.  Otherwise, a malicious guest could use symlinks
to force the host to manipulate the wrong file in the host's namespace.

Idea by Dan Berrange, based on an initial report by Reco
<recoverym4n@gmail.com> at
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=732394

Signed-off-by: Eric Blake <eblake@redhat.com>
(cherry picked from commit aebbcdd33c8c18891f0bdbbf8924599a28152c9c)

Conflicts:
src/lxc/lxc_driver.c: OOM error reporting changes
src/util/virinitctl.c: OOM error reporting changes
src/lxc/lxc_driver.c
src/util/virinitctl.c
src/util/virinitctl.h