CVE-2014-3633: qemu: blkiotune: Use correct definition when looking up disk
authorPeter Krempa <pkrempa@redhat.com>
Thu, 11 Sep 2014 14:35:53 +0000 (16:35 +0200)
committerEric Blake <eblake@redhat.com>
Wed, 17 Sep 2014 22:51:05 +0000 (16:51 -0600)
commit81edcbb3ca1061d5b54945a7e1e9e2e03891307b
treee9309ae62aba68c7a96dae3b7b2aa243727f23bd
parentb850e1a95c5d15700a396d7a5466b43113cb3ab5
CVE-2014-3633: qemu: blkiotune: Use correct definition when looking up disk

Live definition was used to look up the disk index while persistent one
was indexed leading to a crash in qemuDomainGetBlockIoTune. Use the
correct def and report a nice error.

Unfortunately it's accessible via read-only connection, though it can
only crash libvirtd in the cases where the guest is hot-plugging disks
without reflecting those changes to the persistent definition.  So
avoiding hotplug, or doing hotplug where persistent is always modified
alongside live definition, will avoid the out-of-bounds access.

Introduced in: eca96694a7f992be633d48d5ca03cedc9bbc3c9aa (v0.9.8)
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140724
Reported-by: Luyao Huang <lhuang@redhat.com>
Signed-off-by: Peter Krempa <pkrempa@redhat.com>

(cherry picked from commit 3e745e8f775dfe6f64f18b5c2fe4791b35d3546b)
src/qemu/qemu_driver.c