CVE-2013-6456: Avoid unsafe use of /proc/$PID/root in LXC shutdown/reboot code
authorEric Blake <eblake@redhat.com>
Tue, 24 Dec 2013 05:55:51 +0000 (22:55 -0700)
committerDaniel P. Berrange <berrange@redhat.com>
Tue, 18 Feb 2014 13:15:45 +0000 (13:15 +0000)
commitad52184399aa414fa3d7e2756e4ea6a45ec0d3a3
tree5417a802820f1005681d3815d103a84c465d4dad
parent158b5373be2c2dc5aee85e15a8f0f133e91bd7d0
CVE-2013-6456: Avoid unsafe use of /proc/$PID/root in LXC shutdown/reboot code

Use helper virProcessRunInMountNamespace in lxcDomainShutdownFlags and
lxcDomainReboot.  Otherwise, a malicious guest could use symlinks
to force the host to manipulate the wrong file in the host's namespace.

Idea by Dan Berrange, based on an initial report by Reco
<recoverym4n@gmail.com> at
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=732394

Signed-off-by: Eric Blake <eblake@redhat.com>
(cherry picked from commit aebbcdd33c8c18891f0bdbbf8924599a28152c9c)
src/lxc/lxc_driver.c
src/util/virinitctl.c
src/util/virinitctl.h