Really don't crash if a connection closes early
authorJiri Denemark <jdenemar@redhat.com>
Mon, 13 Jan 2014 14:46:24 +0000 (15:46 +0100)
committerEric Blake <eblake@redhat.com>
Wed, 15 Jan 2014 04:37:10 +0000 (21:37 -0700)
commiteb365315ac7784817769704729a69d4a82a71b50
tree3bc65f78514d66d9011b537cfd56d1fba5f05fdf
parentd27401539fe5c52fd6d75559c34189026be9aabb
Really don't crash if a connection closes early

https://bugzilla.redhat.com/show_bug.cgi?id=1047577

When writing commit 173c291, I missed the fact virNetServerClientClose
unlocks the client object before actually clearing client->sock and thus
it is possible to hit a window when client->keepalive is NULL while
client->sock is not NULL. I was thinking client->sock == NULL was a
better check for a closed connection but apparently we have to go with
client->keepalive == NULL to actually fix the crash.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
(cherry picked from commit 066c8ef6c18bc1faf8b3e10787b39796a7a06cc0)
src/rpc/virnetserverclient.c