CVE-2013-6456: Avoid unsafe use of /proc/$PID/root in LXC shutdown/reboot code
authorEric Blake <eblake@redhat.com>
Tue, 24 Dec 2013 05:55:51 +0000 (22:55 -0700)
committerDaniel P. Berrange <berrange@redhat.com>
Tue, 18 Feb 2014 16:34:06 +0000 (16:34 +0000)
commitfef343339127b989746214b86901553da6d17863
tree6326206309a8419846d98b01f524d1ed63c8e3da
parent72e0e071af284eed973fe9d410fb90169f272fd5
CVE-2013-6456: Avoid unsafe use of /proc/$PID/root in LXC shutdown/reboot code

Use helper virProcessRunInMountNamespace in lxcDomainShutdownFlags and
lxcDomainReboot.  Otherwise, a malicious guest could use symlinks
to force the host to manipulate the wrong file in the host's namespace.

Idea by Dan Berrange, based on an initial report by Reco
<recoverym4n@gmail.com> at
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=732394

Signed-off-by: Eric Blake <eblake@redhat.com>
(cherry picked from commit aebbcdd33c8c18891f0bdbbf8924599a28152c9c)
src/lxc/lxc_driver.c
src/util/virinitctl.c
src/util/virinitctl.h