CVE-2015-0236: qemu: Check ACLs when dumping security info from snapshots
authorPeter Krempa <pkrempa@redhat.com>
Tue, 20 Jan 2015 16:01:01 +0000 (17:01 +0100)
committerEric Blake <eblake@redhat.com>
Thu, 22 Jan 2015 18:13:05 +0000 (11:13 -0700)
The ACL check didn't check the VIR_DOMAIN_XML_SECURE flag and the
appropriate permission for it. Found via code inspection while fixing
permissions for save images.

(cherry picked from commit b347c0c2a321ec5c20aae214927949832a288c5a)

src/qemu/qemu_driver.c
src/remote/remote_protocol.x

index 4c1753b..6a20850 100644 (file)
@@ -12863,7 +12863,7 @@ static char *qemuDomainSnapshotGetXMLDesc(virDomainSnapshotPtr snapshot,
     if (!(vm = qemuDomObjFromSnapshot(snapshot)))
         goto cleanup;
 
-    if (virDomainSnapshotGetXMLDescEnsureACL(snapshot->domain->conn, vm->def) < 0)
+    if (virDomainSnapshotGetXMLDescEnsureACL(snapshot->domain->conn, vm->def, flags) < 0)
         goto cleanup;
 
     if (!(snap = qemuSnapObjFromSnapshot(vm, snapshot)))
index 7986b4e..e7b66ca 100644 (file)
@@ -4184,6 +4184,7 @@ enum remote_procedure {
      * @generate: both
      * @priority: high
      * @acl: domain:read
+     * @acl: domain:read_secure:VIR_DOMAIN_XML_SECURE
      */
     REMOTE_PROC_DOMAIN_SNAPSHOT_GET_XML_DESC = 186,