libvirt.git
9 hours agoAppArmor: add mount rules needed with additional mediation features brought by Linux... master
intrigeri [Sun, 19 Nov 2017 14:57:34 +0000]
AppArmor: add mount rules needed with additional mediation features brought by Linux 4.14

This set of rules was proposed by Christian Boltz <apparmor@cboltz.de>
on https://bugzilla.opensuse.org/show_bug.cgi?id=1065123.

9 hours agoAppArmor: add rules needed with additional mediation features brought by Linux 4.14.
intrigeri [Sun, 19 Nov 2017 14:57:33 +0000]
AppArmor: add rules needed with additional mediation features brought by Linux 4.14.

39 hours agolibvirtd: Fix order of cleanup processing
John Ferlan [Mon, 6 Nov 2017 20:20:55 +0000]
libvirtd: Fix order of cleanup processing

Current cleanup processing is ad-hoc at best - it's led to a couple of
strange and hard to diagnose timing problems and crashes.

So rather than perform cleanup in a somewhat random order, let's
perform cleanup in the exact opposite order of startup.

NB: It is possible that virNetlinkEventServerStart fails and we jump
to cleanup before driversInitialized has been set. That could leave
things inconsistent; however, resolution of that possibility is perhaps
more trouble than it's worth to handle.

Signed-off-by: John Ferlan <jferlan@redhat.com>

39 hours agolibvirtd: Alter order of virNetDaemonNew
John Ferlan [Mon, 6 Nov 2017 21:55:15 +0000]
libvirtd: Alter order of virNetDaemonNew

Let's be sure we can get a Daemon object before the server object.
This is a more "orderly" way to do things since the svr object would
be added to the dmn object afterwards.

39 hours agolibvirtd: Move pid_file_fd setup to before run_dir
John Ferlan [Mon, 6 Nov 2017 21:51:02 +0000]
libvirtd: Move pid_file_fd setup to before run_dir

Once we have forked the daemon successfully, let's claim the pidfile
immediately rather than waiting for setup of run_dir.

42 hours agonews: add vmcoreinfo feature details
Marc-André Lureau [Thu, 16 Nov 2017 16:49:39 +0000]
news: add vmcoreinfo feature details

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

42 hours agoqemu: add vmcoreinfo support
Marc-André Lureau [Thu, 16 Nov 2017 16:49:38 +0000]
qemu: add vmcoreinfo support

Starting from qemu 2.11, the `-device vmcoreinfo` will create a fw_cfg
entry for a guest to store dump details, necessary to process kernel
dump with KASLR enabled and providing additional kernel details.

In essence, it is similar to -fw_cfg name=etc/vmcoreinfo,file=X but in
this case it is not backed by a file, but collected by QEMU itself.

Since the device is a singleton and shouldn't use additional hardware
resources, it is presented as a <feature> element in the libvirt
domain XML.

The device is arm/x86 only for now (targets that support fw_cfg+dma).

Related to:
https://bugzilla.redhat.com/show_bug.cgi?id=1395248

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

42 hours agotests: Add resctrl-skx-twocaches test case to vircaps2xmltest
Martin Kletzander [Fri, 10 Nov 2017 13:51:40 +0000]
tests: Add resctrl-skx-twocaches test case to vircaps2xmltest

This doesn't add very much value for now, but future test for virresctrl will
take information from vircaps2xmldata (since it is dependent on the same info
then why duplicate it) and this particular use case helps us cover bit more of
the code regarding proper formatting and handling errors.  And one more test for
vircaps2xmltest doesn't hurt either.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

42 hours agotests: Minor adjustments for test data
Martin Kletzander [Sun, 12 Nov 2017 20:01:46 +0000]
tests: Minor adjustments for test data

This patch modifies some not yet used test data so that the adding a test using
this data is a clean patch and not an addition of huge file with some
adjustments in small files that will be hidden in the middle of that commit.
These changes include:

- Add system dir in vircaps2xmldata/linux-caches

  Back when data for systems with resctrl support were added they had the
  /sys/fs/system directory put into a system/ subdir of the test and
  /sys/fs/resctrl in a resctrl/ subdir of that test.  However, if we also want a
  negative test for the resctrl (requesting allocation on a system that does not
  support resctrl), we need one a test case with any sensible (with cache info)
  system/ subdir and no resctrl/ one.  Easiest way is to add a
  system -> . symlink into existing test case.

- Change default group schemata for linux-resctrl and linux-resctrl-cdp

  That way we can fit some allocation in.

- Remove one cache from resctrl-skx's schemata and make some room for
  allocations

  That system already has only one cache, so that file was wrong anyway.  We
  have a version with 2 caches already (linux-resctrl-skx-twocaches), so this
  will also add variety to future tests.

- Add some empty allocation for resctrl-skx

  Just to have slightly more coverage and variety.  We can be sure nothing bad
  happens if such allocation exists in case we have that in the tests.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>

42 hours agotests: Remove executable bits on plain data files
Martin Kletzander [Fri, 10 Nov 2017 13:48:56 +0000]
tests: Remove executable bits on plain data files

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

42 hours agoconf: Format cache banks in capabilities with virFormatIntPretty
Martin Kletzander [Fri, 10 Nov 2017 12:19:53 +0000]
conf: Format cache banks in capabilities with virFormatIntPretty

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

42 hours agoconf: Sort cache banks in capabilities XML
Martin Kletzander [Fri, 10 Nov 2017 12:19:31 +0000]
conf: Sort cache banks in capabilities XML

Because the cache banks are initialized based on the order in which their
respective directories exist on the filesystem, they can appear in different
order.  This is here mainly for tests because the cache directory might have
different order of children nodes and tests would fail otherwise.  It should not
be the case with sysfs, but one can never be sure.  And this does not take
almost any extra time, mainly because it gets initialized once per driver.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

42 hours agoutil: Introduce virBitmapShrink
Martin Kletzander [Thu, 9 Nov 2017 15:12:33 +0000]
util: Introduce virBitmapShrink

Sometimes the size of the bitmap matters and it might not be guessed correctly
when parsing from some type of input.  For example virBitmapNewData() has Byte
granularity, virBitmapNewString() has nibble granularity and so on.
virBitmapParseUnlimited() can be tricked into creating huge bitmap that's not
needed (e.g.: "0-2,^99999999").  This function provides a way to shrink the
bitmap.  It is not supposed to free any memory.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

42 hours agoutil: Reintroduce virBitmapSubtract
Martin Kletzander [Thu, 5 Oct 2017 13:09:30 +0000]
util: Reintroduce virBitmapSubtract

Already introduced in the past with 9479642fd3c5, but then renamed to
virBitmapIntersect by a908e9e45eb2.  This time we'll really use it.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

42 hours agoutil: Introduce virBitmapNewString
Martin Kletzander [Wed, 23 Aug 2017 07:12:10 +0000]
util: Introduce virBitmapNewString

Our bitmaps can be represented as data (raw bytes for which we have
virBitmapNewData() and virBitmapToData()), human representation (list
of numbers in a string for which we have virBitmapParse() and
virBitmapFormat()) and hexadecimal string (for which we have only
virBitmapToString()).  So let's add the missing complement for the
last one so that we can parse hexadecimal strings.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

42 hours agoutil: Don't output too many zeros from virBitmapToString
Martin Kletzander [Wed, 23 Aug 2017 07:09:17 +0000]
util: Don't output too many zeros from virBitmapToString

Truncate the output so that it is only as big as is needed to fit all
the bits, not all the units from the map.  This will be needed in the
future in order to properly format bitmaps for kernel's sysfs files.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

42 hours agoutil: Rename virBitmapDataToString to virBitmapDataFormat
Martin Kletzander [Wed, 23 Aug 2017 07:05:41 +0000]
util: Rename virBitmapDataToString to virBitmapDataFormat

It is literally only a wrapper around virBitmapNewData() and
virBitmapFormat(), only the naming was wrong since it was introduced.
And because we have virBitmap*String functions where the meaning of
the 'String' is constant, this might confuse someone.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

42 hours agoutil: Rename virBitmapString to virBitmapToString
Martin Kletzander [Tue, 22 Aug 2017 06:30:43 +0000]
util: Rename virBitmapString to virBitmapToString

This follows the virBitmapToData() function and, similarly to
virBitmapNewData(), we'll be able to have virBitmapNewString() later
on without name confusion.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

42 hours agoutil: Make prefix optional in virBitampString
Martin Kletzander [Mon, 21 Aug 2017 06:37:30 +0000]
util: Make prefix optional in virBitampString

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

42 hours agoutil: Introduce virFormatIntPretty
Martin Kletzander [Thu, 9 Nov 2017 15:19:25 +0000]
util: Introduce virFormatIntPretty

We can't output better memory sizes if we want to be compatible with libvirt
older than the one which introduced /memory/unit, but for new things we can just
output nicer capacity to the user if available.  And this function enables that.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

42 hours agoOnly output initialized capabilities with VIR_TEST_DEBUG > 1
Martin Kletzander [Fri, 3 Nov 2017 16:28:10 +0000]
Only output initialized capabilities with VIR_TEST_DEBUG > 1

Currenty virTestInit() outputs all capabilities that it created when running
with VIR_TEST_DEBUG=1.  Since this is quite a lot of output for every call of
this function (and it is not needed until debugging a really deep-down issue)
let's just output the info when VIR_TEST_DEBUG is strictly greater than 1.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>

42 hours agotests: Remove pointless _CFLAGS variables
Martin Kletzander [Thu, 16 Nov 2017 13:24:46 +0000]
tests: Remove pointless _CFLAGS variables

If _CFLAGS for a binary is not specified it uses AM_CFLAGS.  So doing

  $binary_CFLAGS = $(AM_CFLAGS)

or

  $binary_CFLAGS = $(AM_CFLAGS) $(something_that_is_already_in_AM_CFLAGS)

is pointless.  So remove it for cleaner Makefile.am

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>

42 hours agobuild: Use XDR_CFLAGS in more places
Martin Kletzander [Thu, 16 Nov 2017 13:24:45 +0000]
build: Use XDR_CFLAGS in more places

Since update to glibc-2.26 removed the /usr/include/rpc/rpc.h we used until now,
it showed us a problem with not using XDR_CFLAGS properly.  On linux that
variable has usually -I/usr/include/tirpc because we already probe for it
properly, we just don't use it everywhere we need.  It is needed by wireshark
dissector as well as testutilsqemu.c (through includes) so the build fails with:

wireshark/src/packet-libvirt.c:33:10: fatal error: rpc/xdr.h: No such file or directory
 #include <rpc/xdr.h>
          ^~~~~~~~~~~

and

In file included from ../src/logging/log_manager.h:29:0,
                 from ../src/qemu/qemu_domain.h:40,
                 from testutilsqemu.c:11:
../src/logging/log_protocol.h:9:10: fatal error: rpc/rpc.h: No such file or directory
 #include <rpc/rpc.h>
          ^~~~~~~~~~~

Since lot of tests use testutilsqemu.c it is easier to add XDR_CFLAGS to
AM_CFLAGS than adding it to all $binary_CFLAGS.  It's just for tests and we
already have bunch of CFLAGS there anyway.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>

2 days agoxenconfig: fix compilation error
Jim Fehlig [Fri, 17 Nov 2017 17:35:12 +0000]
xenconfig: fix compilation error

Commit 03d0959a introduced a compilation error in
src/xenconfig/xen_xl.c on ARM. Found by Xen's osstest

http://logs.test-lab.xenproject.org/osstest/logs/116216/build-armhf-libvirt/6.ts-libvirt-build.log

2 days agodocs: add a page describing support guarantees for libvirt features
Daniel P. Berrange [Thu, 16 Nov 2017 17:11:55 +0000]
docs: add a page describing support guarantees for libvirt features

While we have collective knowledge about the support status of various
parts of libvirt, this has never been formally documented, leaving our
users to guess.

Note, this document makes one change to our previous policy. It explicitly
declares the RPC protocol of libvirtd as being a supported interface. THis
accepts the reality that we can a) never change it without breaking compat
with old libvirt.so, b) there are both rust + go impls that are written
against the RPC protocol already.

Reviewed-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Jim Fehlig <jfehlig@suse.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>

3 days agodocs: don't use https in XML namespace URIs
Daniel P. Berrange [Fri, 27 Oct 2017 21:39:00 +0000]
docs: don't use https in XML namespace URIs

The XML namespace URI for the QEMU/LXC drivers must use http as the protocol
otherwise it won't match the parser's expectations.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>

3 days agostorage: Resolve storage driver crash
John Ferlan [Mon, 6 Nov 2017 20:22:07 +0000]
storage: Resolve storage driver crash

Resolve a storage driver crash as a result of a long running
storageVolCreateXML when the virStorageVolPoolRefreshThread is
run as a result of when a storageVolUpload completed and ran the
virStoragePoolObjClearVols without checking if the creation
code was currently processing a buildVol after incrementing
the driver->asyncjob count.

The refreshThread will now check the pool asyncjob count before
attempting to pursue the pool refresh. Adjust the documentation
to describe the condition.

Crash from valgrind is as follows (with a bit of editing):

==21309== Invalid read of size 8
==21309==    at 0x153E47AF: storageBackendUpdateVolTargetInfo
==21309==    by 0x153E4C30: virStorageBackendUpdateVolInfo
==21309==    by 0x153E52DE: virStorageBackendVolRefreshLocal
==21309==    by 0x153DE29E: storageVolCreateXML
==21309==    by 0x562035B: virStorageVolCreateXML
==21309==    by 0x147366: remoteDispatchStorageVolCreateXML
...
==21309==  Address 0x2590a720 is 64 bytes inside a block of size 336 free'd
==21309==    at 0x4C2F2BB: free
==21309==    by 0x54CB9FA: virFree
==21309==    by 0x55BC800: virStorageVolDefFree
==21309==    by 0x55BF1D8: virStoragePoolObjClearVols
==21309==    by 0x153D967E: virStorageVolPoolRefreshThread
...
==21309==  Block was alloc'd at
==21309==    at 0x4C300A5: calloc
==21309==    by 0x54CB483: virAlloc
==21309==    by 0x55BDC1F: virStorageVolDefParseXML
==21309==    by 0x55BDC1F: virStorageVolDefParseNode
==21309==    by 0x55BE5A4: virStorageVolDefParse
==21309==    by 0x153DDFF1: storageVolCreateXML
==21309==    by 0x562035B: virStorageVolCreateXML
==21309==    by 0x147366: remoteDispatchStorageVolCreateXML
...

3 days agoqemu: taint domain if virDomainQemuAgentCommand API is used
Pavel Hrdina [Tue, 14 Nov 2017 16:28:48 +0000]
qemu: taint domain if virDomainQemuAgentCommand API is used

This is similar to the virDomainQemuMonitorCommand API, it can change
the domain state in a way that libvirt may not understand.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>

3 days agovirsh: fixing wrong datatype of 'set-lifcycle-action' command options.
Julio Faracco [Thu, 16 Nov 2017 03:01:54 +0000]
virsh: fixing wrong datatype of 'set-lifcycle-action' command options.

The 'set-lifcycle-action' is throwing a weird error after executing it with
the '--help' option. The command output is showing the options 'type' and
'action' are as optional, but they aren't. Both are required.

virsh # set-lifecycle-action --help
...
  SYNOPSIS
    set-lifecycle-action <domain> [--type <string>] [--action <string>] ...
...
  OPTIONS
    [--domain] <string>  domain name, id or uuid
error: internal error: bad options in command: 'set-lifecycle-action'

After applying this patch, both arguments are required now.

virsh # set-lifecycle-action --help
...
  SYNOPSIS
    set-lifecycle-action <domain> <type> <action> [--config] ...

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1509870

Signed-off-by: Julio Faracco <jcfaracco@gmail.com>

4 days agodaemon: virtlockd: Call virNetDaemonGetServer regardless of post exec
Erik Skultety [Tue, 14 Nov 2017 13:35:51 +0000]
daemon: virtlockd: Call virNetDaemonGetServer regardless of post exec

We need to call it anyway, so the else branch is redundant here.

Signed-off-by: Erik Skultety <eskultet@redhat.com>

4 days agodaemon: virtlogd: Drop the server shortcut ref pointer
Erik Skultety [Tue, 14 Nov 2017 13:32:16 +0000]
daemon: virtlogd: Drop the server shortcut ref pointer

We put the server into a hash table as we do with the other daemons,
there is no compelling reason why it should have another pointer
dedicated just to the server. Besides, the locking daemon doesn't have
it and virtlogd is essentially a copy paste of virtlockd.

Signed-off-by: Erik Skultety <eskultet@redhat.com>

4 days agohooks: Fix a wrong description
Chen Hanxiao [Wed, 15 Nov 2017 07:51:40 +0000]
hooks: Fix a wrong description

In the definition of virHookQemuOpType and virHookNetworkOpType,
we should use 'stopped' rather than 'shutdown'.

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>

5 days agonews: Update for configuration of HPT resizing
Andrea Bolognani [Mon, 6 Nov 2017 15:53:36 +0000]
news: Update for configuration of HPT resizing

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

5 days agodocs: Document configuration of HPT resizing
Andrea Bolognani [Mon, 6 Nov 2017 15:40:09 +0000]
docs: Document configuration of HPT resizing

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

5 days agotests: Add tests for configuration of HPT resizing
Andrea Bolognani [Mon, 6 Nov 2017 15:39:58 +0000]
tests: Add tests for configuration of HPT resizing

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

5 days agoqemu: Enable configuration of HPT resizing for pSeries guests
Andrea Bolognani [Mon, 6 Nov 2017 15:39:40 +0000]
qemu: Enable configuration of HPT resizing for pSeries guests

Most of the time it's okay to leave this up to negotiation between
the guest and the host, but in some situations it can be useful to
manually decide the behavior, especially to enforce its availability.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1308743

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

5 days agovircapstest: Avoid (im)possible strcmp call with NULL argument
Jiri Denemark [Mon, 13 Nov 2017 21:22:07 +0000]
vircapstest: Avoid (im)possible strcmp call with NULL argument

Some compilers may get confused and decide we are calling strcmp with
NULL argument from test_virCapsDomainDataLookupLXC. Although this does
not really happen since the call is guarded with
(data->machinetype != expect_machinetype), using STRNEQ_NULLABLE is
easier to understand, less fragile, and doing so makes sure strcmp is
never called with NULL argument.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>

6 days agonews: add entries for specifying distance between vNUMA cells
Jim Fehlig [Fri, 10 Nov 2017 22:01:00 +0000]
news: add entries for specifying distance between vNUMA cells

Add two new entries under new features for 3.10.0. One
advertising support for specifying distance between vNUMA cells
and another advertising Xen's support for vNUMA configuration.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>

6 days agoqemu: Properly report errors from qemuDomainFixupCPUs
Jiri Denemark [Mon, 13 Nov 2017 15:49:47 +0000]
qemu: Properly report errors from qemuDomainFixupCPUs

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>

6 days agoconf: Fix message when maximum vCPU count is less than current
Peter Krempa [Fri, 3 Nov 2017 08:31:30 +0000]
conf: Fix message when maximum vCPU count is less than current

Reword the message and drop the numbers (which were reversed) from it
so that it actually makes sense.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1509151

6 days agoqemu: process: Setup disk secrets when preparing disks
Peter Krempa [Wed, 8 Nov 2017 20:11:47 +0000]
qemu: process: Setup disk secrets when preparing disks

Setup everything related to disks in one place rather than calling in
from various places.

The change to ordering of the setup steps is necessary since secrets
need the master key to be present.

6 days agoqemu: domain: Don't allocate storage source private data if not needed
Peter Krempa [Thu, 9 Nov 2017 11:54:43 +0000]
qemu: domain: Don't allocate storage source private data if not needed

6 days agoqemu: Tolerate storage source private data being NULL
Peter Krempa [Thu, 9 Nov 2017 11:51:25 +0000]
qemu: Tolerate storage source private data being NULL

In some cases it does not make sense to pursue that the private data
will be allocated (especially when we don't need to put anything in it).

Ensure that the code works without it.

This also fixes few crashes pointed out in
https://bugzilla.redhat.com/show_bug.cgi?id=1510323

6 days agoqemu: parse: Allocate disk definition with private data
Peter Krempa [Wed, 8 Nov 2017 19:44:35 +0000]
qemu: parse: Allocate disk definition with private data

Use virDomainDiskDefNew instead of VIR_ALLOC in
qemuParseCommandLineDisk.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1510781

6 days agoqemu: block: Don't leak server JSON object from protocol generators
Peter Krempa [Thu, 9 Nov 2017 09:29:53 +0000]
qemu: block: Don't leak server JSON object from protocol generators

If creation of the main JSON object containing the storage portion of a
virStorageSource would fail but we'd allocate the server structure we'd
leak it. Found by coverity.

6 days agoqemu: block: Break out early on invalid storage sources
Peter Krempa [Thu, 9 Nov 2017 09:13:26 +0000]
qemu: block: Break out early on invalid storage sources

Return NULL right away in qemuBlockStorageSourceGetBackendProps when an
invalid storage source is presented so that virJSONValueObjectAdd isn't
called with a NULL argument.

Found by coverity.

6 days agoconf: Properly parse <backingStore/>
Peter Krempa [Wed, 8 Nov 2017 14:42:51 +0000]
conf: Properly parse <backingStore/>

The terminator would not be parsed properly since the XPath selector was
looking for an populated element, and also the code did not bother
assigning the terminating virStorageSourcePtr to the backingStore
property of the parent.

Some tests would catch it if there wasn't bigger fallout from the change
to backing store termination in a693fdba0111. Fix them properly now.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1509110

6 days agoRevert "virNetDevSupportBandwidth: Enable QoS for vhostuser"
Michal Privoznik [Fri, 10 Nov 2017 15:16:52 +0000]
Revert "virNetDevSupportBandwidth: Enable QoS for vhostuser"

https://bugzilla.redhat.com/show_bug.cgi?id=1497410

This reverts commit bc8a99ef06417a2303ccab455f9f045e2a617916.

The vhostuser is not a TAP. Therefore our QoS code is not able to
set any bandwidth. I don't really understand what I was thinking.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>

7 days agolibxlxml2domconfigtest: add test for vNUMA config
Wim ten Have [Fri, 10 Nov 2017 20:03:16 +0000]
libxlxml2domconfigtest: add test for vNUMA config

Add tests to ensure the libxl_domain_config generator properly
handles vNUMA configuration.

Signed-off-by: Wim ten Have <wim.ten.have@oracle.com>
Reviewed-by: Jim Fehlig <jfehlig@suse.com>
Signed-off-by: Jim Fehlig <jfehlig@suse.com>

7 days agoxlconfigtest: add tests for vNUMA configuration
Wim ten Have [Fri, 10 Nov 2017 19:12:34 +0000]
xlconfigtest: add tests for vNUMA configuration

Add tests for conversion of domXML vNUMA config to/from
xen-xl native vNUMA config.

Signed-off-by: Wim ten Have <wim.ten.have@oracle.com>
Reviewed-by: Jim Fehlig <jfehlig@suse.com>
Signed-off-by: Jim Fehlig <jfehlig@suse.com>

7 days agolibxl: vnuma support
Wim ten Have [Thu, 2 Nov 2017 15:47:22 +0000]
libxl: vnuma support

This patch generates a NUMA distance-aware libxl description from the
information extracted from a NUMA distance-aware libvirt XML file.

By default, if no NUMA node distance information is supplied in the
libvirt XML file, this patch uses the distances 10 for local and 20
for remote nodes/sockets.

Signed-off-by: Wim ten Have <wim.ten.have@oracle.com>
Reviewed-by: Jim Fehlig <jfehlig@suse.com>
Signed-off-by: Jim Fehlig <jfehlig@suse.com>

7 days agoxenconfig: add domxml conversions for xen-xl
Wim ten Have [Thu, 2 Nov 2017 15:47:21 +0000]
xenconfig: add domxml conversions for xen-xl

This patch converts NUMA configurations between the Xen libxl
configuration file format and libvirt's XML format.

XML HVM domain on a 4 node (2 cores/socket) configuration:

  <cpu>
    <numa>
      <cell id='0' cpus='0-1' memory='2097152' unit='KiB'>
        <distances>
          <sibling id='0' value='10'/>
          <sibling id='1' value='21'/>
          <sibling id='2' value='31'/>
          <sibling id='3' value='21'/>
        </distances>
      </cell>
      <cell id='1' cpus='2-3' memory='2097152' unit='KiB'>
        <distances>
          <sibling id='0' value='21'/>
          <sibling id='1' value='10'/>
          <sibling id='2' value='21'/>
          <sibling id='3' value='31'/>
        </distances>
      </cell>
      <cell id='2' cpus='3-4' memory='2097152' unit='KiB'>
        <distances>
          <sibling id='0' value='31'/>
          <sibling id='1' value='21'/>
          <sibling id='2' value='10'/>
          <sibling id='3' value='21'/>
        </distances>
      </cell>
      <cell id='3' cpus='5-6' memory='2097152' unit='KiB'>
        <distances>
          <sibling id='0' value='21'/>
          <sibling id='1' value='31'/>
          <sibling id='2' value='21'/>
          <sibling id='3' value='10'/>
        </distances>
      </cell>
    </numa>
  </cpu>

Xen xl.cfg domain configuration:

  vnuma = [["pnode=0","size=2048","vcpus=0-1","vdistances=10,21,31,21"],
           ["pnode=1","size=2048","vcpus=2-3","vdistances=21,10,21,31"],
           ["pnode=2","size=2048","vcpus=4-5","vdistances=31,21,10,21"],
           ["pnode=3","size=2048","vcpus=6-7","vdistances=21,31,21,10"]]

If there is no XML <distances> description amongst the <cell> data the
conversion schema from xml to native will generate 10 for local and 20
for all remote instances.

Signed-off-by: Wim ten Have <wim.ten.have@oracle.com>
Reviewed-by: Jim Fehlig <jfehlig@suse.com>
Signed-off-by: Jim Fehlig <jfehlig@suse.com>

7 days agonuma: describe siblings distances within cells
Wim ten Have [Thu, 2 Nov 2017 15:47:20 +0000]
numa: describe siblings distances within cells

Add support for describing NUMA distances in a domain's <numa> <cell>
XML description.

Below is an example of a 4 node setup:

  <cpu>
    <numa>
      <cell id='0' cpus='0-3' memory='2097152' unit='KiB'>
        <distances>
          <sibling id='0' value='10'/>
          <sibling id='1' value='21'/>
          <sibling id='2' value='31'/>
          <sibling id='3' value='21'/>
        </distances>
      </cell>
      <cell id='1' cpus='4-7' memory='2097152' unit='KiB'>
        <distances>
          <sibling id='0' value='21'/>
          <sibling id='1' value='10'/>
          <sibling id='2' value='21'/>
          <sibling id='3' value='31'/>
        </distances>
      </cell>
      <cell id='2' cpus='8-11' memory='2097152' unit='KiB'>
        <distances>
          <sibling id='0' value='31'/>
          <sibling id='1' value='21'/>
          <sibling id='2' value='10'/>
          <sibling id='3' value='21'/>
        </distances>
      <cell id='3' cpus='12-15' memory='2097152' unit='KiB'>
        <distances>
          <sibling id='0' value='21'/>
          <sibling id='1' value='31'/>
          <sibling id='2' value='21'/>
          <sibling id='3' value='10'/>
        </distances>
      </cell>
    </numa>
  </cpu>

A <cell> defines a NUMA node. <distances> describes the NUMA distance
from the <cell> to the other NUMA nodes (the <sibling>s).  For example,
in above XML description, the distance between NUMA node0 <cell id='0'
...> and NUMA node2 <sibling id='2' ...> is 31.

Valid distance values are '10 <= value <= 255'.  A distance value of 10
represents the distance to the node itself.  A distance value of 20
represents the default value for remote nodes but other values are
possible depending on the physical topology of the system.

When distances are not fully described, any missing sibling distance
values will default to 10 for local nodes and 20 for remote nodes.

If distance is given for A -> B, then we default B -> A to the same
value instead of 20.

Signed-off-by: Wim ten Have <wim.ten.have@oracle.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Jim Fehlig <jfehlig@suse.com>

7 days agoremote: Set *neventCallbacks to zero at DEREG_CB
xinhua.Cao [Sat, 11 Nov 2017 08:30:41 +0000]
remote: Set *neventCallbacks to zero at DEREG_CB

To avoid the chance that the loop is run twice, set the neventCallbacks
to zero after VIR_FREE(eventCallbacks) was called.

9 days agotests: fix TTY check in virTestUseTerminalColors()
Pino Toscano [Thu, 9 Nov 2017 12:31:03 +0000]
tests: fix TTY check in virTestUseTerminalColors()

Since colors would be used when writing to stdout, then check that
stdout is a TTY, instead of stdin.

This avoids the usage of terminal color codes when the output is
directed to file.

9 days agoqemuBuildDriveDevStr: Prefer default aliases for IDE bus
Michal Privoznik [Thu, 9 Nov 2017 12:34:43 +0000]
qemuBuildDriveDevStr: Prefer default aliases for IDE bus

https://bugzilla.redhat.com/show_bug.cgi?id=1434451

When testing user aliases it was discovered that for 440fx
machine type which has default IDE bus builtin, domain cannot
start if IDE controller has the user provided alias. This is
because for 440fx we don't put the IDE controller onto the
command line (since it is builtin) and therefore any device that
is plugged onto the bus must use the default alias.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>

10 days agonuma: avoid failure in nodememstats on non-NUMA systems
Viktor Mihajlovski [Fri, 22 Sep 2017 14:12:23 +0000]
numa: avoid failure in nodememstats on non-NUMA systems

libvirt reports a fake NUMA topology in virConnectGetCapabilities
even if built without numactl support. The fake NUMA topology consists
of a single cell representing the host's cpu and memory resources.
Currently this is the case for ARM and s390[x] RPM builds.

A client iterating over NUMA cells obtained via virConnectGetCapabilities
and invoking virNodeGetMemoryStats on them will see an internal failure
"NUMA isn't available on this host" from virNumaGetMaxNode. An example
for such a client is VDSM.

Since the intention seems to be that libvirt always reports at least
a single cell it is necessary to return "fake" node memory statistics
matching the previously reported fake cell in case NUMA isn't supported
on the system.

Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>

10 days agonews: Update for vbox 5.2 support
Dawid Zamirski [Tue, 7 Nov 2017 22:44:31 +0000]
news: Update for vbox 5.2 support

10 days agovbox: Add support for 5.2.x
Dawid Zamirski [Tue, 7 Nov 2017 22:36:34 +0000]
vbox: Add support for 5.2.x

Simply add the 5.2 SDK header to the existing unified framework. No
other special handling is needed as there's no API break between
existing 5.1 and the just added 5.2.

10 days agovbox: Add vbox 5.2 CAPI header file.
Dawid Zamirski [Tue, 7 Nov 2017 22:22:08 +0000]
vbox: Add vbox 5.2 CAPI header file.

Extracted from 5.2 SDK and reindented with cppi

10 days agovirconf: properly set the end of content
Jim Fehlig [Tue, 7 Nov 2017 21:20:44 +0000]
virconf: properly set the end of content

There was a recent report of the xen-xl converter not handling
config files missing an ending newline

https://www.redhat.com/archives/libvir-list/2017-October/msg01353.html

Commit 3cc2a9e0 fixed a similar problem when parsing content of a
file but missed parsing in-memory content. But AFAICT, the better
fix is to properly set the end of the content when initializing the
virConfParserCtxt in virConfParse().

This commit reverts the part of 3cc2a9e0 that appends a newline to
files missing it, and fixes setting the end of content when
initializing virConfParserCtxt. A test is also added to check
parsing in-memory content missing an ending newline.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

10 days agoconf: Fix type for @liveStatus in virDomainObjListLoadAllConfigs
Peter Krempa [Wed, 8 Nov 2017 14:17:33 +0000]
conf: Fix type for @liveStatus in virDomainObjListLoadAllConfigs

Use bool instead of an int.

11 days agoqemu-ns: Detect /dev/* mount point duplicates even better
Michal Privoznik [Wed, 8 Nov 2017 14:20:10 +0000]
qemu-ns: Detect /dev/* mount point duplicates even better

In 4f1570720218302 I've tried to make duplicates detection for
nested /dev mount better. However, I've missed the obvious case
when there are two same mount points. For instance if:

  # mount --bind /dev/blah /dev/blah
  # mount --bind /dev/blah /dev/blah

Yeah, very unlikely (in qemu driver world) but possible.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>

11 days agoutil: storage: Fix parsing of IPv6 portal address for iSCSI
Peter Krempa [Tue, 7 Nov 2017 15:20:23 +0000]
util: storage: Fix parsing of IPv6 portal address for iSCSI

Split on the last colon and avoid parsing port if the split remainder
contains the closing square bracket, so that IPv6 addresses are
interpreted correctly.

11 days agotests: Add caps for QEMU 2.10.0 on ppc64
Andrea Bolognani [Fri, 3 Nov 2017 16:26:30 +0000]
tests: Add caps for QEMU 2.10.0 on ppc64

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

11 days agotests: Rename ppc64le caps to ppc64
Andrea Bolognani [Mon, 6 Nov 2017 11:40:24 +0000]
tests: Rename ppc64le caps to ppc64

The architecture itself is called ppc64, and it can run both in big
endian and little endian mode - the latter is known as ppc64le.

From the (virtual) hardware point of view, ppc64 is a more accurate
name so it should be used here.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

11 days agotests: Add caps for QEMU 2.10.0 on aarch64 (GICv3)
Andrea Bolognani [Mon, 6 Nov 2017 11:23:35 +0000]
tests: Add caps for QEMU 2.10.0 on aarch64 (GICv3)

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

11 days agotests: Add caps for QEMU 2.10.0 on aarch64 (GICv2)
Andrea Bolognani [Mon, 6 Nov 2017 11:23:22 +0000]
tests: Add caps for QEMU 2.10.0 on aarch64 (GICv2)

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

11 days agonews: Document predictable file names for memory-backend-file
Michal Privoznik [Tue, 24 Oct 2017 09:59:29 +0000]
news: Document predictable file names for memory-backend-file

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

11 days agoqemu: Use predictable file names for memory-backend-file
Michal Privoznik [Tue, 7 Nov 2017 14:20:12 +0000]
qemu: Use predictable file names for memory-backend-file

In some cases management application needs to allocate memory for
qemu upfront and then just let qemu use that. Since we don't want
to expose path for memory-backend-file anywhere in the domain
XML, we can generate predictable paths. In this case:

  $memoryBackingDir/libvirt/qemu/$shortName/$alias

where $shortName is result of virDomainDefGetShortName().

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

11 days agoqemu: Destroy whole memory tree
Michal Privoznik [Tue, 7 Nov 2017 15:03:40 +0000]
qemu: Destroy whole memory tree

When removing path where huge pages are call virFileDeleteTree
instead of plain rmdir(). The reason is that in the near future
there's going to be more in the path than just files - some
subdirs. Therefore plain rmdir() is not going to be enough.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

11 days agoqemu: Rename qemuProcessBuildDestroyHugepagesPath
Michal Privoznik [Tue, 7 Nov 2017 14:19:43 +0000]
qemu: Rename qemuProcessBuildDestroyHugepagesPath

At the same time, move its internals into a separate function so
that they can be reused.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

11 days agoqemu: Set alias for memory cell in qemuBuildMemoryCellBackendStr
Michal Privoznik [Tue, 7 Nov 2017 14:12:33 +0000]
qemu: Set alias for memory cell in qemuBuildMemoryCellBackendStr

Very soon qemuBuildMemoryBackendStr() is going to use memory cell
aliases. Therefore set one. At the same time, move it a bit
further - if virAsprintf() fails, there's no point in setting
rest of the members.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

12 days agodocs: Document autoport behavior in the vbox driver
Dawid Zamirski [Tue, 7 Nov 2017 21:36:48 +0000]
docs: Document autoport behavior in the vbox driver

12 days agodocs: Update vbox driver documentation.
Dawid Zamirski [Tue, 7 Nov 2017 21:36:47 +0000]
docs: Update vbox driver documentation.

* libvirt no longer supports vbox <= 3.x
* update XML definition sample to show how to attach disks to VBOX's SAS
  controller and how to change IDE controller model.
* update XML to show how to create RDP display with autoport.

12 days agocputest: Add data for Intel(R) Core(TM) i7-7700 CPU
Jiri Denemark [Mon, 2 Oct 2017 13:51:21 +0000]
cputest: Add data for Intel(R) Core(TM) i7-7700 CPU

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

12 days agocputest: Add data for Intel(R) Xeon(R) CPU E5-2650 v4
Jiri Denemark [Thu, 2 Nov 2017 19:50:25 +0000]
cputest: Add data for Intel(R) Xeon(R) CPU E5-2650 v4

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

12 days agocputest: Do not drop v[0-9] from CPU names
Jiri Denemark [Thu, 2 Nov 2017 13:43:37 +0000]
cputest: Do not drop v[0-9] from CPU names

Version is a significant part of some Xeon CPUs.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>

12 days agodocs: Update news.xml with vbox changes.
Dawid Zamirski [Tue, 7 Nov 2017 18:49:30 +0000]
docs: Update news.xml with vbox changes.

12 days agovbox: Add SAS controller support
Dawid Zamirski [Tue, 7 Nov 2017 18:49:29 +0000]
vbox: Add SAS controller support

In VirtualBox SAS and SCSI are separate controller types whereas libvirt
does not make such distinction. This patch adds support for attaching
the VBOX SAS controllers by mapping the 'lsisas1068' controller model in
libvirt XML to VBOX SAS controller type. If VBOX VM has disks attached
to both SCSI and SAS controller libvirt domain XML will have two
<controller type='scsci'> elements with index and model attributes set
accordingly. In this case, each respective <disk> element must have
<address> element specified to assign it to respective SCSI controller.

12 days agovbox: Generate disk address element in dumpxml
Dawid Zamirski [Tue, 7 Nov 2017 18:49:28 +0000]
vbox: Generate disk address element in dumpxml

This patch adds <address> element to each <disk> device since device
names alone won't adequately reflect the storage device layout in the
VM. With this patch, the ouput produced by dumpxml will faithfully
reproduce the storage layout of the VM if used with define.

12 days agovbox: Process empty removable disks in dumpxml
Dawid Zamirski [Tue, 7 Nov 2017 18:49:27 +0000]
vbox: Process empty removable disks in dumpxml

Previously any removable storage device without media attached was
omitted from domain XML dump. They're still (rightfully) omitted in
snapshot XML dump but need to be accounted properly to for the device
names to stay in 'sync' between domain and snapshot XML dumps.

12 days agovbox: Cleanup vboxDumpDisks implementation
Dawid Zamirski [Tue, 7 Nov 2017 18:49:26 +0000]
vbox: Cleanup vboxDumpDisks implementation

Primer the code for further changes:

* move variable declarations to the top of the function
* group together free/release statements
* error check and report VBOX API calls used

12 days agovbox: Correctly generate drive name in dumpxml
Dawid Zamirski [Tue, 7 Nov 2017 18:49:25 +0000]
vbox: Correctly generate drive name in dumpxml

If a VBOX VM has e.g. a SATA and SCSI disk attached, the XML generated
by dumpxml used to produce "sda" for both of those disks. This is an
invalid domain XML as libvirt does not allow duplicate device names. To
address this, keep the running total of disks that will use "sd" prefix
for device name and pass it to the vboxGenerateMediumName which no
longer tries to "compute" the value based only on current and max
port and slot values. After this the vboxGetMaxPortSlotValues is not
needed and was deleted.

12 days agovbox: Swap vboxSnapshotGetReadOnlyDisks arguments
Dawid Zamirski [Tue, 7 Nov 2017 18:49:24 +0000]
vbox: Swap vboxSnapshotGetReadOnlyDisks arguments

So that the function signature matches vboxSnapshotGetReadWriteDisks

12 days agovbox: Do not free disk definitions on cleanup
Dawid Zamirski [Tue, 7 Nov 2017 18:49:23 +0000]
vbox: Do not free disk definitions on cleanup

Both vboxSnapshotGetReadWriteDisks and vboxSnapshotGetReadWriteDisks do
not need to free the def->disks on cleanup because it's being done by
the caller via virDomainSnaphotDefFree

12 days agovbox: Cleanup/prepare snasphot dumpxml functions
Dawid Zamirski [Tue, 7 Nov 2017 18:49:22 +0000]
vbox: Cleanup/prepare snasphot dumpxml functions

This patch prepares the vboxSnapshotGetReadOnlyDisks and
vboxSnapshotGetReadWriteDisks functions for further changes so that
the code movement does not obstruct the gist of those future changes.
This is done primarily because we'll need to know the type of vbox
storage controller as early as possible and make decisions based on
that info.

12 days agovbox: Rename vboxDumpIDEHDDs to vboxDumpDisks
Dawid Zamirski [Tue, 7 Nov 2017 18:49:21 +0000]
vbox: Rename vboxDumpIDEHDDs to vboxDumpDisks

Because it deals with other disk types as well not just IDE. Also this
function now returns -1 on error

12 days agovbox: Add vboxDumpStorageControllers
Dawid Zamirski [Tue, 7 Nov 2017 18:49:20 +0000]
vbox: Add vboxDumpStorageControllers

12 days agovbox: Process <controller> element in domain XML
Dawid Zamirski [Tue, 7 Nov 2017 18:49:19 +0000]
vbox: Process <controller> element in domain XML

With this patch, the vbox driver will no longer attach all supported
storage controllers by default even if no disk devices are associated
with them. Instead, it will attach only those that are implicitly added
by virDomainDefAddImplicitController based on <disk> element or if
explicitly specified via the <controller> element.

12 days agovbox: Cleanup partially-defined VM on failure
Dawid Zamirski [Tue, 7 Nov 2017 18:49:18 +0000]
vbox: Cleanup partially-defined VM on failure

Since the VBOX API requires to register an initial VM before proceeding
to attach any remaining devices to it, any failure to attach such
devices should result in automatic cleanup of the initially registered
VM so that the state of VBOX registry remains clean without any leftover
"aborted" VMs in it. Failure to cleanup of such partial VMs results in a
warning log so that actual define error stays on the top of the error
stack.

12 days agostorage: Privatize virStoragePoolObj and virStorageVolDefList
John Ferlan [Wed, 26 Jul 2017 19:13:28 +0000]
storage: Privatize virStoragePoolObj and virStorageVolDefList

Move the structures into virstorageobj so that both are known
within virstorageobj.c.

12 days agostorage: Use virStoragePoolObjGetDef accessor for new driver events
John Ferlan [Fri, 6 Oct 2017 14:31:34 +0000]
storage: Use virStoragePoolObjGetDef accessor for new driver events

Missed from merge from commit id 'b0652192' into commit id 'bfcd8fc92'
were a couple of obj->def-> references.

12 days agostorage: Use virStoragePoolObjGetDef accessor for ZFS backend
John Ferlan [Wed, 26 Jul 2017 18:39:54 +0000]
storage: Use virStoragePoolObjGetDef accessor for ZFS backend

In preparation for privatizing the object, use the accessor.

12 days agostorage: Use virStoragePoolObjGetDef accessor for VSTORAGE backend
John Ferlan [Wed, 26 Jul 2017 18:36:46 +0000]
storage: Use virStoragePoolObjGetDef accessor for VSTORAGE backend

In preparation for privatizing the object, use the accessor.

12 days agostorage: Use virStoragePoolObjGetDef accessor for SCSI backend
John Ferlan [Wed, 26 Jul 2017 18:34:57 +0000]
storage: Use virStoragePoolObjGetDef accessor for SCSI backend

In preparation for privatizing the object, use the accessor.

12 days agostorage: Use virStoragePoolObjGetDef accessor for RBD backend
John Ferlan [Wed, 26 Jul 2017 18:32:09 +0000]
storage: Use virStoragePoolObjGetDef accessor for RBD backend

In preparation for privatizing the object, use the accessor.

12 days agostorage: Use virStoragePoolObjGetDef accessor for MPATH backend
John Ferlan [Wed, 26 Jul 2017 18:28:16 +0000]
storage: Use virStoragePoolObjGetDef accessor for MPATH backend

In preparation for privatizing the object, use the accessor.

12 days agostorage: Use virStoragePoolObjGetDef accessor for iSCSI backend
John Ferlan [Wed, 26 Jul 2017 18:26:27 +0000]
storage: Use virStoragePoolObjGetDef accessor for iSCSI backend

In preparation for privatizing the object, use the accessor.

12 days agoapparmor, virt-aa-helper: allow ipv6
Christian Ehrhardt [Fri, 3 Nov 2017 08:46:59 +0000]
apparmor, virt-aa-helper: allow ipv6

In case ipv6 is used the network inet6 permission is required for
virt-aa-helper.

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>